Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (6cb26a3) to head (aadd788).
Report is 48 commits behind head on stage.

@@           Coverage Diff           @@
##            stage    #3536   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         260      260           
  Lines       60582    60584    +2     
=======================================
+ Hits        58444    58446    +2     
  Misses       2138     2138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

For the failing NALA tests you could try to clear the cache with this:
CURL -si -X POST https://admin.hlx.page/code/sharmeeatadobe/milo/mwpw-158773/\*

This might need another look, I see that the image is now in a different position than before. I'm guessing this isn't intentional? The paragraph may have different spacing rules that could differ from / add to the image's ones

This is a specific issue due to the image asset itself because the ratio of dimensions of the default image within <picture> tag is not matching the dimensions of the image that gets satisfied.
Whereas I did not find this issue where the ratios are maintained. Tried with few examples here: Eg: https://main--milo--adobecom.hlx.page/drafts/sharmeeb/aside-notification vs https://mwpw-158773--milo--sharmeeatadobe.hlx.page/drafts/sharmeeb/aside-notification

For the failing NALA tests you could try to clear the cache with this: CURL -si -X POST https://admin.hlx.page/code/sharmeeatadobe/milo/mwpw-158773/\*

I have tried this a couple of times but cache refresh did not help overcome the failed NALA test. Can we please re-run this since the tests are failing for a an unrelated component wrt this PR

@sharmeeatadobe - we can't ask authors to start changing such images, especially since we don't have a way to figure out all the pages where this might occur. Backwards compatibility needs to be maintained, without affecting layout. The tablet view would be even more affected with this change:

We don't want to introduce visual regressions in favor of minor performance enhancements, other solutions should be considered to address this.

CC: @SilviuLCF

@sharmeeatadobe - we can't ask authors to start changing such images, especially since we don't have a way to figure out all the pages where this might occur. Backwards compatibility needs to be maintained, without affecting layout. The tablet view would be even more affected with this change:

We don't want to introduce visual regressions in favor of minor performance enhancements, other solutions should be considered to address this.

CC: @SilviuLCF

Sure, I'll try with some alternative solution. Do you have any suggestions in mind?